GH-9: Fixed type errors. #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shallwefootball
requested changes
Jul 18, 2020
action.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| name: Upload S3 | |||
| name: Upload S3 - Fix GH-9 | |||
There was a problem hiding this comment.
I think it is unnecessary '- Fix GH-9'
remove plz
index.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| // @ts-check | |||
README.md
Outdated
| | name | description | | ||
| | ------------------ | --------------------------------------------------------------------------------------------- | | ||
| | `object_key` | Uploaded object key generated by [shortid](https://github.com/dylang/shortid) in Bucket | | ||
| | `object_locations` | The URLs of the uploaded objects as a JSON string. E.g: `["location/file1","location/file2"]` | |
There was a problem hiding this comment.
why use the array to string??
this is intended to control by pragmatically in other actions
There was a problem hiding this comment.
@kittaakos you're right.
must have to stringify Object.
but core was update this actions/toolkit#370
so could you update @actions/core?
|
@shallwefootball, sorry for the delay and messing up with the PRs. I opened a follow-up with a bare minimum changeset. Here is the follow-up: #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messageof theErrorobject.fromjson.object_locationsvalue.dist.Closes #9
Signed-off-by: Akos Kitta kittaakos@typefox.io