Issue67 (#68)

* Issue 67 * Issue 67 * Issue 67
shamblett · Oct 13, 2024 · dbff585 · dbff585
1 parent cae3709
commit dbff585
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 5 deletions.
diff --git a/lib/src/xml2json_open_rally.dart b/lib/src/xml2json_open_rally.dart
@@ -68,8 +68,7 @@ class _Xml2JsonOpenRally {
       } else if (children.isNotEmpty) {
         ret.addAll({_toJsonString(node.name.local): children});
       } else {
-        ret.addAll(
-            {_toJsonString(node.name.local): _toJsonString(true.toString())});
+        ret.addAll({_toJsonString(node.name.local): null});
       }
       return ret;
     } else if (node is XmlText) {
@@ -91,7 +90,7 @@ class _Xml2JsonOpenRally {
       json = _recursiveParse(xmlNode, attributePrefix: attributePrefix);
     } on Exception catch (e) {
       throw Xml2JsonException(
-          'Parker internal transform error => ${e.toString()}');
+          'OpenRally internal transform error => ${e.toString()}');
     }
     return json.toString();
   }

diff --git a/test/issue67_test.dart b/test/issue67_test.dart
@@ -0,0 +1,24 @@
+@TestOn('vm')
+library;
+
+import 'package:test/test.dart';
+import 'package:xml2json/xml2json.dart';
+
+void main() {
+  const input = "<root><item></item><name>john</name></root>";
+
+  test('OpenRally', () {
+    final xmlParser = Xml2Json();
+    xmlParser.parse(input);
+    var jsonResponse = xmlParser.toOpenRally();
+    expect(jsonResponse, '{"root": {"item": null, "name": "john"}}');
+  });
+
+  test('Parker', () {
+    final xmlParser = Xml2Json();
+    xmlParser.parse(input);
+    var jsonResponse = xmlParser.toParker();
+    print(jsonResponse);
+    expect(jsonResponse, '{"root": {"item": null, "name": "john"}}');
+  });
+}
diff --git a/test/xml2json_test_strings.dart b/test/xml2json_test_strings.dart
@@ -567,10 +567,10 @@ String openRallyStringJson = """
         "extensions":{
           "distance":"0",
           "cap":"328",
-          "show_coordinates":"true",
+          "show_coordinates":null,
           "tulip":"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAY4AAA...",
           "notes":"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAY4AAA...",
-          "timecontrol":"true"
+          "timecontrol": null
         }
       },
       {