Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement upload delay setting #390

Closed
Jasius opened this issue Aug 24, 2017 · 11 comments
Closed

Implement upload delay setting #390

Jasius opened this issue Aug 24, 2017 · 11 comments

Comments

@Jasius
Copy link

Jasius commented Aug 24, 2017

Visual Studio Code Version : 1.15
Code Settings Sync Version : 2.8.3
Operating System : Windows 10 Creators update
Occurs On: Upload
Proxy Enabled: No
GIst Id: https://gist.github.com/Jasius/1d63509b67a4fdf1c3344aa8d90826d2

Hey,

One thing that annoys me the most about this extension is that there's a very short delay upon which upload gets triggered, so lets say whenever you're changing settings, making snippets it uploads all those unfinished changes which in 5 seconds which is unreasonable time frame in my opinion.

My proposal is so that there would be an option which would allow you to set up delay in settings or just make default upload delay 1 minute.

Cheers, Jaska.

@shanalikhan
Copy link
Owner

I think it's better to start the Upload process on Settings and extension changes.
Currently, the auto upload doesn't work well. A goal is to make it behave well instead of having scheduled.

@shanalikhan shanalikhan removed this from the Backlog milestone Oct 11, 2018
@Jasius
Copy link
Author

Jasius commented Oct 11, 2018

I see, thank you @shanalikhan

@ZaLiTHkA
Copy link

ZaLiTHkA commented Jun 6, 2019

@shanalikhan, just curious, but have you been able to implement the improvements you mentioned above?

I was about to open an issue and make the same request when I found this one. Thing is, personally I'd actually like to set something like a 30 second or even 1 minute delay before it auto uploads..

Is there any chance of having a configurable delay for this until such time as you change the way it works?

@shanalikhan
Copy link
Owner

@ZaLiTHkA may i know why you want to add a delay.
It would be more easy to understand if you could provide a real-time scenario to show the need for this feature.

@ZaLiTHkA
Copy link

sorry for the delay, I've been away from my computer this whole weekend..

I would like a delay in the upload for essentially the same reasons that @Jasius gave: when making changes to things like system settings, key bindings, installed extensions, custom snippets, etc., this extension is constantly uploading the changes.


from a usability point of view inside VSCode, I suppose this isn't really an issue, but when looking at the change history in the relevant GitHub Gist, it gets really difficult to see all the changes that were made over the period of mere minutes.

@shanalikhan shanalikhan reopened this Jun 10, 2019
@shanalikhan shanalikhan added this to the Backlog milestone Jun 10, 2019
@Jasius
Copy link
Author

Jasius commented Jun 12, 2019

I felt the same, I have auto sync disabled nowadays because it was a little frustrating without delay.

@shanalikhan shanalikhan modified the milestones: Backlog, v3.4.0 Jun 19, 2019
@shanalikhan
Copy link
Owner

@arnohovhannisyan Lets add this in v3.4.0 also.

I think we can add autoUploadDelay in Global Settings make it default as 20 seconds.
Users can change the delay in terms of seconds for uploading.

@Jasius
Copy link
Author

Jasius commented Jun 25, 2019

That's awesome, thank you! @shanalikhan

@auxves auxves mentioned this issue Jun 25, 2019
3 tasks
shanalikhan pushed a commit that referenced this issue Jun 25, 2019
* Auto Upload Delay

* Fix bug

* Fix updated localization
@shanalikhan
Copy link
Owner

v3.4.0 is released containing this fix.
Let me know if you run into issue

@PHLAK
Copy link

PHLAK commented Aug 22, 2019

I have v3.4.2 installed and don't see this setting available anywhere. It also does not autocomplete when I attempt to edit my settings file manually.

@shanalikhan
Copy link
Owner

@PHLAK

See Settings Sync Global Settings

https://github.com/shanalikhan/code-settings-sync#global-settings

Config is autoUploadDelay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants