-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto upload doesn't work when make change on settings #801
Comments
Exactly same behavior on Arch Linux. 🌴 Visual Studio Code Version : [ 1.32.3 ] |
Same on Windows 10 1809 Build 17763.379 |
* Fix auto upload! * Properly stop watching * Add synchronous functions * Move watcher to a new service * Make a new service for watcher * Add general ignored items setting for chokidar * Use globalCommons's autoUploadService instance * Reset * Add local settings to ignored files * Asynchronously get ignored items * Remove unused import * Use autoUploadService * Use the globalCommonService everywhere Since the autoUploadService is an instance in Commons, using a global Commons instance will allow everything to use the same instance. * Stop spamming with extension paths * Fix to work with async functions * Add global state to ignored files * Add .DS_Store and sync.lock * Start watcher only after downloading has finished * Inform user that auto upload has started
* #806 * prettify custom setting json (#812) * Fix auto upload (#801) * Fix auto upload! * Properly stop watching * Add synchronous functions * Move watcher to a new service * Make a new service for watcher * Add general ignored items setting for chokidar * Use globalCommons's autoUploadService instance * Reset * Add local settings to ignored files * Asynchronously get ignored items * Remove unused import * Use autoUploadService * Use the globalCommonService everywhere Since the autoUploadService is an instance in Commons, using a global Commons instance will allow everything to use the same instance. * Stop spamming with extension paths * Fix to work with async functions * Add global state to ignored files * Add .DS_Store and sync.lock * Start watcher only after downloading has finished * Inform user that auto upload has started * #805 * #820 * #820 * #821 * #805 * #823 * Go back to webpack and fix source maps * Ignore node_modules and some other files (#826)
Its fixed in v2.3.8. Update and let me know |
@shanalikhan Thanks for creating sync-settings - it's really great. I am running into this same issue and I am using the latest version Visual Studio Code Version : [ 1.40.2 ] I have "sync.autoUpload" set to true and yet on changing settings i.e. making changes to settings.json in VSCode the gist isn't updated. Just wanted to check if I should file a new issue or is there any additional debugging info I can provide? |
@shanalikhan hi , autoupload stopped working for the last couple of months
|
Auto upload doesn't work when make change on settings (MAC)
auto uploading is on.
using cmd+, to open settings page, make change config change. sync setting doesn't upload settings.
if I open settings.json file and press cmd+s to save the file, sync setting starts sync after 5 seconds, worked as expected.
🌴 Visual Studio Code Version : [ 1.32.3 ]
🌴 Code Settings Sync Version : [ 3.2.7 ]
🌴 Standard or Insiders : [ standard ]
🌴 OSS or Portable : [ here ]
🌴 Operating System : [ Macpro mojave 10.14.3 ]
🌴 Occurs On: [Upload]
🌴 Proxy Enabled: [ No ]
🌴 Gist Id: [ ID_HERE ]
📰 To Reproduce
Steps to reproduce the behavior:
open settings page, make change.
sync setting didn't upload setting
💪 Expected behavior
sync setting should upload upon new change.
📺 Console Error Log
If applicable, add screenshots or paste the console log from developer console of VSCode.
no
📺 Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: