Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language support- traditional chinese #1028

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Add language support- traditional chinese #1028

merged 2 commits into from
Sep 2, 2019

Conversation

YunChaoTsai
Copy link
Contributor

@YunChaoTsai YunChaoTsai commented Sep 1, 2019 •
edited
Loading

Short description of what this resolves:

Add translation traditional chinese.

Changes proposed in this pull request:

  • add package.nls.zh-tw.json

Fixes: #1028

How Has This Been Tested?

Screenshots (if appropriate):

image

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.
  • Have you checked the number of keys starting with Sync : should be equal to the other language files.
  • Can you post the screen shoots

@YunChaoTsai YunChaoTsai changed the title add translation file add translation traditional chinese Sep 1, 2019
@YunChaoTsai YunChaoTsai changed the title add translation traditional chinese Improvement - add translation traditional chinese Sep 1, 2019
@YunChaoTsai
Copy link
Contributor Author

Should I update this page wiki/Add-or-Improve-Language-Support before pull request merged?

@YunChaoTsai YunChaoTsai changed the title Improvement - add translation traditional chinese Add language support- traditional chinese Sep 1, 2019
@shanalikhan
Copy link
Owner

  1. Have you checked the number of keys starting with Sync : should be equal to the other language files.
  2. Can you post the screen shoots

Yes you can update the page once above verification steps are completed and this PR is ready to merge.

@shanalikhan shanalikhan added this to the v3.4.3 milestone Sep 2, 2019
@shanalikhan shanalikhan merged commit 8902a74 into shanalikhan:v3.4.3 Sep 2, 2019
@shanalikhan
Copy link
Owner

PR is merged, you can update the wiki :)

@YunChaoTsai
Copy link
Contributor Author

Thank you always.
I have updated the wiki.

@YunChaoTsai YunChaoTsai deleted the feat/add-traditional-chinese branch September 2, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement ✨
Projects
None yet
Milestone
v3.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@YunChaoTsai @shanalikhan