silencing share gist info message on quietSync

[ramblingjordan]

Short description of what this resolves:

Prevents cmd.updateSettings.info.shareGist from showing as a vscode information message during auto upload when quietSync is enabled.

Changes proposed in this pull request:

• Adds condition to if statement that displays message requiring quietSync to be false to display.
• Only effects the information message statement. No other code lines would be effected.

Fixes: #1033

How Has This Been Tested?

I have not been able to test this personally. I am having trouble running the extension in the debugger so I have not verified operation. Hoping to elicit some help on Slack or here to consider this done since I'm thinking the solution takes priority over my education. :)

Screenshots (if appropriate):

N/A

Checklist:

• I have read the contribution guidelines.
• My change requires a change to the documentation and GitHub Wiki.
• I have updated the documentation and Wiki accordingly.

[shanalikhan]

Adds condition to if statement that displays message requiring quietSync to be false to display.

Thank you for the PR, but this dialog has nothing to do with quietSync.

The intend to show this dialog is only on upload, when the user selects Share Settings with Public Gist from Sync : Advance Settings and choose to upload the settings into new gist. This dialog shouldn't show on normal upload process.

It would be great if you can debug the code of Share Settings with Public Gist and see what parameters it is sending for the upload.

[shanalikhan]

I have fixed it in the commit e150b2d

Can you verify if it's working for you by installing the attached package of extension? (that is scheduled for upcoming release)

code-settings-sync-3.4.3.zip

[ramblingjordan]

VERIFIED! It does not show the prompt.

Steps I took:

• Made a settings change
• Verified status bar showed change and prompted upload in 20 seconds.
• Waited 20 seconds ;)
• Verified status bar showed uploading took place.
• Verified no info box loaded up.

Thank you very much!

[shanalikhan]

I have marked it as fixed and scheduled for next release. Meanwhile if you find the error in the above feel free to report :)