Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insiders build fails to get extension list #432

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

sonhanguyen
Copy link
Contributor

Replace the unreliable check for packageJSON.__metadata (not present in insiders) with extensionPath.
This is to address #428

@shanalikhan
Copy link
Owner

This change fix the insiders, will current stable VS Code work with this ?

@sonhanguyen
Copy link
Contributor Author

@shanalikhan I tested both, seem to work.

@sonhanguyen
Copy link
Contributor Author

sonhanguyen commented Oct 31, 2017

I'm not happy with hardcoding the extension directory (.vscode(-insiders)?) though. There is a flag (--extensionHomePath) that overrides this but I could not find the api to get it.

@shanalikhan shanalikhan merged commit 7cd7aaa into shanalikhan:master Nov 2, 2017
@shanalikhan
Copy link
Owner

Yes, there are many things need to done from API side.
I'm looking for contributors so i can guide them and make this extension more smooth and with rich features.
Let me know if you are willing to work with other issues.

Thanks,
P.s will release new version tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants