NOMERGE: Always use VSCODE_PORTABLE env when portable #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mac will no longer use Application Support while in portable mode
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seems too simple to me, so I wouldn't find someone else looking over it before merging. I'm wondering, why the extension was set to save to application support in the first place when in portable mode, especially if all other OS's were set to save to VSCODE_PORTABLE?
Short description of what this resolves:
This attempts to resolve #684, support portable version on mac
Changes proposed in this pull request:
I believe this is the proper behavior, as while portable we don't want any data to be saved to any part of the fine system other than the portable directory.
How Has This Been Tested?
Tested on VSCode 1.29.1, running the latest clone of code-settings-sync
macOS 10.14.2, MacBookPro11,3.
Tested initial gist creation, successful settings upload then download.
Checklist: