Remove Disabling of TLS Certificates #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, Will be released in next version. |
shanalikhan
pushed a commit
that referenced
this pull request
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This removes disabling of TLS certificate validation, which side effects into any other process running within VS Code.
This closes #776
If any users report SSL trust issues, they need to fix the issue with VS Code in general, and it should not be handled by an extension. More information on how to properly trust certificates can be found here: https://code.visualstudio.com/docs/setup/network#_ssl-certificates
Edit: Worst case, the user with the issue can turn it off in VS Code if they wish with
--ignore-certificate-errors, but it should not be the default for everyone.