Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "bin/bash" to "/bin/bash" when OsType is Linux in pluginService #795

Closed
wants to merge 1 commit into from

Conversation

kiprasmel
Copy link

@kiprasmel kiprasmel commented Mar 8, 2019

Change "bin/bash" to "/bin/bash" in pluginService

I suppose this would fix
#668

(additional testing needed)

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

I suppose this would fix
#668

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel kiprasmel changed the title Change "bin/bash" to "/bin/bash" in pluginService Change "bin/bash" to "/bin/bash" when OsType is Linux in pluginService Mar 8, 2019
@shanalikhan
Copy link
Owner

(additional testing needed)

Can you test the on the following editions.

  1. Standard Code on Linux
  2. Insiders Code on Linux
  3. OSS Code versions on linux.

I will accept the PR, if it works for all of them. ( first two version are working as of now, need to test 3rd one while it dont break the first two)

@kiprasmel
Copy link
Author

kiprasmel commented Mar 12, 2019

I will soon, but I think that the pull request #739 is more appropriate - it says to fix the issue of not synchronising & installing extensions on linux oss. I think that testing & applying it out would be better, but I'll look into this as well.

@shanalikhan
Copy link
Owner

Yes, that pull request is looking like exposing the path for OSS users, and I personally would like some code that would set the path itself by reading some env. variables or any other logic to setup for OSS.

@shanalikhan
Copy link
Owner

Closing this PR, let me know when its done or ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants