Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that autoUploadService is set before using it #835

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Make sure that autoUploadService is set before using it #835

merged 3 commits into from
Apr 9, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Apr 8, 2019

Short description of what this resolves:

This resolves issues with autoUploadService being undefined when using its methods.

Changes proposed in this pull request:

  • Add new methods to make sure that autoUploadService is set
  • Initialize autoUploadService before calling functions if not set

Fixes: #832

How Has This Been Tested?

Tested by @ActionCactus

Checklist:

@ActionCactus
Copy link

ActionCactus commented Apr 8, 2019

If I may:

I think the interface change you've made to commons is a good cleanup, but it doesn't appear the root cause of the issue was found. What changed with the bootstrap that would prevent commons' constructor from initializing autoUploadService properly?

Thanks for tackling this - figured I at least owed you a code review.

@shanalikhan shanalikhan added this to the v3.2.9 milestone Apr 8, 2019
src/sync.ts Outdated Show resolved Hide resolved
@shanalikhan shanalikhan changed the base branch from master to v3.2.9 April 8, 2019 05:50
@auxves
Copy link
Contributor Author

auxves commented Apr 9, 2019

@shanalikhan I just committed the changes that you requested.

@shanalikhan shanalikhan merged commit d7b5a6d into shanalikhan:v3.2.9 Apr 9, 2019
@auxves auxves deleted the stopwatching-of-undefined branch June 19, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants