Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues on first install #922

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Fix issues on first install #922

merged 1 commit into from
Jun 24, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Jun 24, 2019

Short description of what this resolves:

This PR fixes issues that would occur on the first install of this extension.

Changes proposed in this pull request:

  • Return default customConfig if it's not set yet
  • Check if a file exists before reading it

How Has This Been Tested?

Tested by debugging extension.

Checklist:

@shanalikhan shanalikhan added this to the v3.3.1 milestone Jun 24, 2019
@shanalikhan shanalikhan changed the base branch from master to v3.3.1 June 24, 2019 21:06
@shanalikhan shanalikhan merged commit 0f28791 into shanalikhan:v3.3.1 Jun 24, 2019
shanalikhan pushed a commit that referenced this pull request Jun 25, 2019
#922
6f0b604
shanalikhan pushed a commit that referenced this pull request Jun 25, 2019
#922
fe19495
shanalikhan pushed a commit that referenced this pull request Jun 25, 2019
#922
763b171
shanalikhan pushed a commit that referenced this pull request Jun 25, 2019
#922
6047b76
shanalikhan added a commit that referenced this pull request Jun 25, 2019
@shanalikhan
V3.3.1 (#924)
ebdca4f 
* Rename package.nls.pt.json to package.nls.pt-br.json

This aligns the filename to the one needed by VSCode.

* Fix issues on first install

* #922

* #922

* #922
@auxves auxves deleted the fix-issues-on-first-install branch June 25, 2019 12:24
shanalikhan pushed a commit that referenced this pull request Jun 27, 2019
@greenkeeper @shanalikhan
Update @types/fs-extra to the latest version 🚀 (#929)
b57c586 
* V3.3.1 (#924)

* Rename package.nls.pt.json to package.nls.pt-br.json

This aligns the filename to the one needed by VSCode.

* Fix issues on first install

* #922

* #922

* #922

* chore(package): update @types/fs-extra to version 8.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@auxves @shanalikhan