Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Page: Don't Show This Again #960

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Landing Page: Don't Show This Again #960

merged 2 commits into from
Jul 18, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Jul 16, 2019

Short description of what this resolves:

This PR adds a button to not show the landing page, even if the extension is not configured.

Changes proposed in this pull request:

  • Use context.globalState to keep track of preference
  • Reset the preference when resetting extension settings
  • Don't show the landing page if enabled

Fixes: #959 (comment)

Checklist:

@shanalikhan
Copy link
Owner

Can you setup this configuration like the image

image

Position should be right-aligned to Sponsors. If you have any ideas than suggest.

@shanalikhan shanalikhan changed the base branch from master to v3.4.1 July 16, 2019 14:06
@shanalikhan shanalikhan added this to the v3.4.1 milestone Jul 16, 2019
@shanalikhan
Copy link
Owner

@arnohovhannisyan
Can you fix it today so i can release new version.
Not getting good response from the users ( in emails, reviews etc)

@auxves
Copy link
Contributor Author

auxves commented Jul 17, 2019

@shanalikhan I should be able to finish it today, but it might take a while since I'm currently away from home.

@auxves
Copy link
Contributor Author

auxves commented Jul 17, 2019

@shanalikhan

If you have any ideas than suggest.

How about we put the checkbox pinned on the bottom right of the page. This way it's easily spotted. It also doesn't have anything to do with sponsors.

@shanalikhan
Copy link
Owner

Yes, go ahead. Do share the image.

@auxves
Copy link
Contributor Author

auxves commented Jul 17, 2019

@shanalikhan

image

@shanalikhan shanalikhan merged commit bdf437f into shanalikhan:v3.4.1 Jul 18, 2019
@shanalikhan
Copy link
Owner

shanalikhan commented Jul 18, 2019

@arnohovhannisyan
There are some improvement that can improve the UX.
What are your views about it. We can ship these improvements with v3.4.1

  1. On Startup
    When user click on Login with Github and click on skip button. There dialog should be appeared to user that GIST is not configured, Settings Sync will create new GIST on Upload.

  2. On Upload
    When token and GIST is not configured, page does open along with the warning of invalid GIST.

    • Invalid GIST error should not appear when GIST is empty.
    • When user gets the token and select any gist. It should start the upload process automatically as User is coming from On Upload process.
    • If user click on Skip button, it should start the upload process create the new GIST as User is coming from On Upload Process.
  3. On Download
    When token and GIST is not configured, page does open along with Invalid GIST error.

    • Invalid GIST error should not appear when GIST is empty.
    • When user gets the token
    • On Gist Page, Skip button should be hidden as user wants to download, instead we can show close button to stop the process.
    • When user select any GIST, it should start downloading process as user is coming from On Download process
  4. New Github user.
    If there is no GIST available to Github user attached. Login to Github does not show anything that it has fetched the token. We need to show that screen everytime even there is no GIST attached. ( tried to new github account)

  5. Transfer the Github Application ownership to my account (@shanalikhan).

@shanalikhan
Copy link
Owner

shanalikhan commented Jul 18, 2019

@arnohovhannisyan

Error:

I have disabled the check.
Now when Settings sync isnot configured, on upload it doesnt open the configuration page to setup, instead gives error of invalid token.

Can you fix it when possible i'm looking to release new version.

shanalikhan added a commit that referenced this pull request Jul 18, 2019
@auxves
Copy link
Contributor Author

auxves commented Jul 18, 2019

@shanalikhan

Transfer the Github Application ownership to my account

I have already initiated the transfer.

Can you fix it when possible i'm looking to release new version.

Yes, I will create a PR soon

@shanalikhan
Copy link
Owner

shanalikhan commented Jul 18, 2019

I have disabled the check. Now when Settings sync isnot configured, on upload it doesnt open the configuration page to setup, instead gives error of invalid token.

I have fixed this check.

You can include the things discussed here #960 (comment) and one more thing in PR.

i-e
The Show at startup is always checked, we need to bind to its current value. To show unchecked if not checked. When opened via upload / download process

@auxves auxves mentioned this pull request Jul 18, 2019
1 task
@auxves auxves deleted the dont-show-again-landing-page branch July 22, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants