Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n of zh-cn #961

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Improve i18n of zh-cn #961

merged 1 commit into from
Jul 16, 2019

Conversation

ziofat
Copy link

@ziofat ziofat commented Jul 16, 2019

Short description of what this resolves:

Most translation are broken for zh_CN in recent updates.

Changes proposed in this pull request:

I fixed the translations for zh_CN.

Fixes: #

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

@fisker
Copy link

fisker commented Jul 16, 2019

哈哈 我们竟然同时做了一件事。。。 #962

@shanalikhan shanalikhan added this to the v3.4.1 milestone Jul 16, 2019
@shanalikhan shanalikhan changed the base branch from master to v3.4.1 July 16, 2019 13:28
@shanalikhan shanalikhan merged commit 95811ee into shanalikhan:v3.4.1 Jul 16, 2019
@ziofat
Copy link
Author

ziofat commented Jul 16, 2019

@fisker 我是中午看到 VSCode 自动弹出了更新提示,写着“释放笔记”这样奇怪的词。所以就来了。

@shanalikhan I think translated strings should not be overwrite by machine translations. I didn't find any scripts related to translation but if there is one I'd like to try to compose a PR for that.

@fisker
Copy link

fisker commented Jul 16, 2019

我也是 释放笔记 写的审核 看得我一脸懵

@linsui linsui mentioned this pull request Jul 17, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants