Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translating update #994

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Conversation

mijien0179
Copy link
Contributor

fixing some wrong translate.

Short description of what this resolves:

Just fixing some mistake translate

Changes proposed in this pull request:

  • package.nls.ko.json fixing

Fixes: #

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

fixing some wrong translate.
@shanalikhan
Copy link
Owner

Can you start the keys with Sync:

We need to make standard consistent across all languages. You can the Sync : prefix on the keys in the following file.
https://github.com/shanalikhan/code-settings-sync/blob/master/package.nls.zh-cn.json

Although translated, it some case may not be accurate.
@mijien0179
Copy link
Contributor Author

I'm completed your request. but this translating may be mistake in some case. because I'm not sure where do its using per each item.

@shanalikhan shanalikhan changed the base branch from master to v3.4.2 August 9, 2019 06:51
@shanalikhan
Copy link
Owner

I have updated the branch. Someone from the last week also improved the korean language.
Can you resolve the conflicts?

@mijien0179
Copy link
Contributor Author

solve

@shanalikhan shanalikhan merged commit 76e820c into shanalikhan:v3.4.2 Aug 9, 2019
@shanalikhan shanalikhan added this to the v3.4.2 milestone Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants