Fix bad file descriptor crashes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly close the pipe file handle after the data has been read.
tonyarnold
approved these changes
Nov 12, 2024
|
@simonbs Can you please check this and approve the workflow when you get a chance? |
simonbs
approved these changes
Nov 14, 2024
|
Looks great! Thanks for contributing these changes! 🙏 |
|
I am not very familiar with Swift, any tips how to handle potential error here as the force try is a lint error. |
|
@kuhnroyal No worries. I've pushed some changes that should address it. |
|
Thanks! |
|
This is included in 0.10.1 which was just published. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly close the pipe file handle after the data has been read.
Motivation and Context
Fixes #93
Fixes #76
Screenshots (if appropriate):
Types of changes