Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure keychain items are accessible after the device was locked #99

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kuhnroyal
Copy link
Contributor

Description

By setting kSecAttrAccessibleAfterFirstUnlock when writing keychain items, these should be readable even after the device is locked due to lock screen etc.

I tested this locally and now Tartelet happily keeps creating new VMs even if the lock screen is activated.

Motivation and Context

Closes #98

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

By setting `kSecAttrAccessibleAfterFirstUnlock` when writing keychain items, these should be readable even after the device is locked due to lock screen etc.
@kuhnroyal kuhnroyal changed the title Ensure keychain items are accessible after the device was unlocked Ensure keychain items are accessible after the device was locked Nov 14, 2024
Copy link
Contributor

@simonbs simonbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a sane approach to me. Thanks for opening a PR with the changes! 🙏

@simonbs simonbs merged commit e6bcb76 into shapehq:main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keychain locked?
2 participants