This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: optional icons property in Asset type #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
5 tasks
0xdef1cafe
approved these changes
Mar 29, 2023
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
# [@shapeshiftoss/asset-service-v8.12.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/asset-service-v8.11.2...@shapeshiftoss/asset-service-v8.12.0) (2023-03-29) ### Features * optional icons property in Asset type ([#1229](#1229)) ([10e9c9c](10e9c9c))
|
🎉 This PR is included in version @shapeshiftoss/asset-service-v8.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that Zapper allows us to introspect LP tokens data, and thus display programmatic Uni-V2 LP assets, not just the current hardcoded ETH/FOX staking, we will need to display both icons to differentiate UNI-V2 LP assets.
This adds a new
icons: string[]property allowing us to do this. See the matching web draft shapeshift/web#4148