Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: phantom wire-up #7766

Merged
merged 30 commits into from
Sep 25, 2024
Merged

feat: phantom wire-up #7766

merged 30 commits into from
Sep 25, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 18, 2024

Description

Spotted issues so far:

Issue (if applicable)

closes #7622

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

NOTE: Polygon Txs are currently borked upstream https://github.com/shapeshift/hdwallet/pull/677/commits. Waiting for a resolution in https://github.com/orgs/phantom/discussions/294 - assume Polygon isn't working, so Polygon has been disabled for the time being.
should only show up in accounts for the time being, but not actionable as far as Txs go. If resolution takes too long, will disable Polygon support in hdwallet-land before we ship this, so that Polygon doesn't show up as an account.

  • Accounts (BTC, ETH~~, and Polygon~~) are happy
  • Txs are properly detected
  • Sends are happy
  • Savers Deposit and Withdraw are happy
  • BTC <-> ETH swaps are happy
  • ☝🏽

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ☝🏽

Screenshots (if applicable)

  • ETH Native Send
image
  • Ethereum token send
image
  • Ethereum Receive
image
  • ETH -> BTC swap
image image
  • BTC self-send
image image image
  • ETH Savers deposit
image image
  • Token Savers Deposit
image image
  • BTC Savers Deposit
image image image
  • ETH Savers Withdraw
image
  • BTC Savers Withdraw
image image

@gomesalexandre gomesalexandre changed the title [skip ci] wip: phantom wire-up feat: phantom wire-up Sep 20, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review September 20, 2024 22:28
@gomesalexandre gomesalexandre requested a review from a team as a code owner September 20, 2024 22:28
@kaladinlight
Copy link
Contributor

Account change is not working. There are no accounts emitted on the accountsChanged event so we treat the wallet as locked and abort. We should attempt to pair in this case so we can requests accounts and in turn establish the connection to the new account.

@gomesalexandre gomesalexandre enabled auto-merge (squash) September 25, 2024 21:56
@gomesalexandre gomesalexandre merged commit a6d3a38 into develop Sep 25, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_phantom_wire_up branch September 25, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phantom Wallet Support
2 participants