Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade OTel dependencies #2

Merged
merged 1 commit into from
Mar 29, 2023
Merged

feat: upgrade OTel dependencies #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ license = "MIT"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
opentelemetry = { version = "0.17" }
opentelemetry = "0.18"
Copy link
Contributor Author

@SimenB SimenB Mar 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that 0.19 is available, but tracing-opentelemetry is not updated yet. It's on its way out from the main repo, so I'm not sure when it'll be updated.

tonic = "0.8"
tracing = "0.1"
tracing-opentelemetry = "0.17"
tracing-opentelemetry = "0.18"
8 changes: 4 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ pub fn otel_thread_cx_to_req<T>(request: &mut Request<T>){
});
}


#[cfg(test)]
mod tests {
use opentelemetry::{global, Context};
Expand All @@ -94,7 +94,7 @@ mod tests {
export::trace::stdout
};
use opentelemetry::trace::{Tracer, TraceContextExt};

use super::MetadataExtractor;

use super::MetadataInjector;
Expand Down Expand Up @@ -128,7 +128,7 @@ mod tests {
propagator.extract(&MetadataExtractor(request.metadata()))
});

let span = tracer.start_with_context("server-span", &cx);
let _span = tracer.start_with_context("server-span", &cx);

}
}