Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RED-268: add cycle to unjoin request #18

Merged
merged 1 commit into from
Sep 5, 2024
Merged

RED-268: add cycle to unjoin request #18

merged 1 commit into from
Sep 5, 2024

Conversation

justin-shardeum
Copy link

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Consistency Issue
The cycleNumber and sign fields were removed and then re-added with potentially the same functionality. Ensure that these changes are intentional and consistent with the application's data handling requirements.

Missing Field Validation
The newly added cycleNumber in UnjoinRequest and other interfaces lacks validation. Consider adding checks to ensure the cycle number is within expected ranges or formats.

afostr
afostr approved these changes Sep 4, 2024
View reviewed changes
Copy link

@afostr afostr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mhanson-github mhanson-github merged commit 3657967 into dev Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afostr afostr afostr approved these changes

Assignees
No one assigned
Labels
Review effort [1-5]: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justin-shardeum @afostr @mhanson-github @magonjr