Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit error events individually per node in tellBinary #8

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Emit error events individually per node in tellBinary #8

merged 3 commits into from
Apr 30, 2024

Conversation

S0naliThakur
Copy link
Member

@S0naliThakur S0naliThakur requested a review from arhamj April 19, 2024 14:08
@S0naliThakur S0naliThakur self-assigned this Apr 19, 2024
@linear Linear
Copy link

linear bot commented Apr 19, 2024

GOLD-46 Debug the lost_report undefined string warning log 

[2024-04-16T10:42:28.844] [WARN] p2p - Comms: tellBinary: network.tellBinary: P2P TELL_BINARY: failed. route: binary/lost_report, error: TypeError [ERR_INVALID_ARG_TYPE]: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received undefined
  • Which string in the payload is causing this issue?
  • Repro
    • Stop one of the running nodes manually
  • Add logging
    • askBinary

Guess

  1. Due to rotation removing the node to be reported as lost

arhamj
arhamj reviewed Apr 21, 2024
View reviewed changes
src/network/index.ts Outdated Show resolved Hide resolved
@arhamj arhamj changed the base branch from dev to GOLD-58 April 30, 2024 05:24
@arhamj arhamj merged commit 34936dc into GOLD-58 Apr 30, 2024
2 checks passed
mhanson-github pushed a commit that referenced this pull request Apr 30, 2024
@S0naliThakur @arhamj @mhanson-github
Emit error events individually per node in tellBinary (#8)
cd26f51 
* Emit error events individually per node in tellBinary

* style(format): fixed formatting

* comment out multiSendWithHeader error emitter

---------

Co-authored-by: Arham Jain <arham.nec@gmail.com>
afostr pushed a commit that referenced this pull request May 4, 2024
@S0naliThakur @arhamj @afostr
Emit error events individually per node in tellBinary (#8)
b1062c2 
* Emit error events individually per node in tellBinary

* style(format): fixed formatting

* comment out multiSendWithHeader error emitter

---------

Co-authored-by: Arham Jain <arham.nec@gmail.com>
thantsintoe pushed a commit that referenced this pull request May 6, 2024
@S0naliThakur @arhamj @thantsintoe
Emit error events individually per node in tellBinary (#8)
57c215d 
* Emit error events individually per node in tellBinary

* style(format): fixed formatting

* comment out multiSendWithHeader error emitter

---------

Co-authored-by: Arham Jain <arham.nec@gmail.com>
@arhamj arhamj deleted the GOLD-46 branch May 13, 2024 07:34
urnotsam pushed a commit that referenced this pull request May 17, 2024
@S0naliThakur @arhamj
Emit error events individually per node in tellBinary (#8)
4b417fc 
* Emit error events individually per node in tellBinary

* style(format): fixed formatting

* comment out multiSendWithHeader error emitter

---------

Co-authored-by: Arham Jain <arham.nec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhamj arhamj arhamj approved these changes

Assignees

@S0naliThakur S0naliThakur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S0naliThakur @arhamj