Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary text elements #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

curran
Copy link

@curran curran commented Oct 15, 2016

This is a proof-of-concept change that adds support for arbitrary text elements, in addition to input and textarea. I tested this manually using the <h1> element, and it seems to work well. Please let me know if this change would be welcome. If so I can add some tests for it. Thank you.

Closes #1

@Karalix
Copy link

Karalix commented Jan 10, 2017

This is definetly a problem I was running into using this library, as I wanted to use a contenteditable element instead of an input/textarea. Others may encounter the same frustration. If you don't mind I would like to use your modifications for my student project.

@curran
Copy link
Author

curran commented Jul 10, 2017

@Karalix Please do use it! I'm happy to find it would be useful for you.

@nateps Any chance of reviewing this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants