proposed change for street names #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@migurski here's my first attempt at including street names into the metadata tiles
Backed out name in SharedStreetsMetadata -- that can be computed from OSM Metadata. Added name to OSMMetadata parent for multiple way sections with the same name value. Only record different names in WaySections.
| @@ -37,10 +37,13 @@ message WaySection { | |||
| bool roundabout = 4; | |||
| bool link = 5; | |||
| repeated uint64 nodeIds = 6; | |||
|
|
|||
| string name = 7; // name only stored here if different for each way section, otherwise captured in OSMMetadata | |||
There was a problem hiding this comment.
👍 Seems reasonable to me
|
Looks good to me! |
|
Once merged, I'll update the following repos: |
DenisCarriere
added a commit
to sharedstreets/sharedstreets-pbf
that referenced
this pull request
Mar 12, 2018
|
Great! Merging now and regenerating the tiles |
|
@kpwebb 👍 Great stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@migurski here's my first attempt at including street names into the metadata tiles