[PGE-178206904] Send Transaction ID to STX #1544
Conversation
`source.tid` is transaction id at the request level `bidReq.ortb2Imp` may carry a transaction id at the impression level (`imp.ext.tid`) Followed recommendations provided by contributors here: prebid#8573 PGE-178206904
maphe
requested review from
javadreamer,
jefftmahoney and
balbinas
and removed request for
a team
modules/sharethroughBidAdapter.js
Outdated
| const impression = {}; | ||
| const impression = { ext: {} }; | ||
|
|
||
| mergeDeep(impression, bidReq.ortb2Imp); |
There was a problem hiding this comment.
Are we sure that we want this - since it merges everrything in from the bid request? Will STX properly ignore what its not expecting to receive in the bid request? Are we sure that there risk is minimal of impression requests being potentially larger than expected (full of additional fields that mean nothing to the exchange?)
I recommend sanity checking, if you haven't already done so, this approach with STX Core, specifically via the universal endpoint. Not opposed per se, but want to make sure supply and exchange are aligned on this change.
There was a problem hiding this comment.
Well, it doesn't merge "everything", it merges what Prebid allows the publishers to inject in the requests, from the doc:
ortb2Impis used to signal OpenRTB Imp objects at the adUnit grain. Similar to the global ortb2 field used for global first party data configuration, but specific to this adunit. Theortb2Impobject currently supports first party data including the Prebid Ad Slot and the interstitial signal.
from which everything lives in the ext field.
I can ask STX but I believe we already have a some fields that STX does not care about but DSPs do, so it would fall into the same category. I think the universal endpoint mostly acts as a passthrough since both input and output are openRTB formatted, allowing us at the adapter level to leverage as much Prebid features as we can and let DSPs read or ignore as they will.
There was a problem hiding this comment.
Conversation opened with STX here: https://sharethrough.slack.com/archives/G03A4C37B/p1661982990805279
|
Opened PR on official public repo: prebid#8988 |
source.tidis transaction id at the request levelbidReq.ortb2Impmay carry a transaction id at the impression level (imp.ext.tid)While Prebid is still figuring out how they want to do it, this is following the same implementation as TheTradeDesk did in their own adapter so we know the transaction id is at least consistent with them (since they're the one asking for it in the first place). My understanding is that if ever the Prebid committee changes the spec, they will be the one updating all adapters like they did in the past for other changes.
Followed recommendations provided by contributors here: prebid#8573
PGE-178206904