Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/etc/crypttab "as an alias to" -lfstab #1073

Closed
stdedos opened this issue Jun 25, 2020 · 4 comments · Fixed by #1192
Closed

/etc/crypttab "as an alias to" -lfstab #1073

stdedos opened this issue Jun 25, 2020 · 4 comments · Fixed by #1192
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@stdedos
Copy link

stdedos commented Jun 25, 2020

With the exception for the spurious red in 1024, I think formatting/output looks overall better

image

@stdedos stdedos added the feature-request New feature or request label Jun 25, 2020
@sharkdp
Copy link
Owner

sharkdp commented Jun 26, 2020

Thank you for the feedback. Sounds good!

This would be a simple addition in Fstab.sublime-syntax. In the meantime, you can add

--map-syntax='/etc/crypttab:fstab'

to your bat config file.

Not sure if the 1024 highlighting is intended. @eth-p ?

@sharkdp sharkdp added the good first issue Good for newcomers label Jun 26, 2020
@stdedos
Copy link
Author

stdedos commented Jun 26, 2020

Well, pedantically speaking, the format is somewhat similar, but not 1-for-1 similar (or, maybe by more strictly defining /etc/fstab, /etc/crypttab may also be supported).

However, as shown, one-liner merge now to me is better than a complicated fix/addition much later / never.

Given that batrc change is easy, lgtm either way.

From inferring the syntax from the output, I think that "a lot of things" are highlighted when following an = (but it's weird why isn't the case with UUID as shown here).

@eth-p
Copy link
Collaborator

eth-p commented Jun 27, 2020

Not sure if the 1024 highlighting is intended. @eth-p ?

When I did the syntax stuff, I wasn't really selective about the highlighting on that part of the fstab format.

The syntax will just highlight the values in the key=value pairs without any consideration to whether or not they're actually valid options.

@sharkdp
Copy link
Owner

sharkdp commented Oct 2, 2020

This is now supported in v0.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants