Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom --highlight-line color #1699

Closed
akharrou opened this issue Jun 20, 2021 · 6 comments
Closed

Allow custom --highlight-line color #1699

akharrou opened this issue Jun 20, 2021 · 6 comments
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@akharrou
Copy link

akharrou commented Jun 20, 2021

I really LOVE the --highlight-line option, but some themes just don't seem to take it into account, i.e due to the color choice, the highlighted line is very hard to read. Was just wondering if there's any way, currently, of changing the coloring of the highlighted line ?


Theme: TwoDark

...too light, almost not even there:

image


Theme: base16-ocean.dark (external theme)

too strong, can barely read what the line is saying:

image

comments are even worse, you don't even know if there's anything on the line:

image

@akharrou akharrou added the question Further information is requested label Jun 20, 2021
@zachriggle
Copy link

👍 @sharkdp this would be great to be able to customize.

@Enselic Enselic changed the title Is it possible to specify the color of the --highlight-line option ? Allow custom --highlight-line color Aug 4, 2021
@Enselic Enselic added feature-request New feature or request good first issue Good for newcomers and removed question Further information is requested labels Aug 4, 2021
@Enselic
Copy link
Collaborator

Enselic commented Aug 4, 2021

There currently is no way, but should be pretty easy to add.

@keith-hall
Copy link
Collaborator

potentially related: #1745

@Enselic
Copy link
Collaborator

Enselic commented Aug 4, 2021

Thanks, I forgot we had a feature request for that. Let's close as duplicate.

@Enselic
Copy link
Collaborator

Enselic commented Aug 4, 2021

Duplicate of #339

@Enselic Enselic marked this as a duplicate of #339 Aug 4, 2021
@app
Copy link

app commented Oct 11, 2021

While waiting update I use sed workaround in fzf.vim setup

  command! -bang -nargs=* GGrep
    \ call fzf#vim#grep(
    \   'git grep --line-number '.shellescape(<q-args>), 0,
    \   {'options':['--preview', 'bat --color=always --theme="Solarized (dark)" --style=numbers -H {2}  --line-range :500 {1}| sed s/"48;2;28;209;255"/"4;2;28;209;255"/g']}, <bang>0)

It gives me underline in preview window
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants