Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to add a theme without blowing away languages? #172

Closed
kaolin opened this issue Jun 22, 2018 · 4 comments · Fixed by #204
Closed

no way to add a theme without blowing away languages? #172

kaolin opened this issue Jun 22, 2018 · 4 comments · Fixed by #204
Labels
feature-request New feature or request
Milestone

Comments

@kaolin
Copy link

kaolin commented Jun 22, 2018

It would be really nice to be able to either add a theme to the existing themes, or at least be able to create your own set of themes without losing all of the languages/syntaxes....

I'll admit I may be doing something wrong.

Installed bat via homebrew. Followed instructions to create appropriate theme directory and added a theme. Couldn't reinit cache without creating a syntax directory. Reiniting cache then made it so I had just the two themes I had added, and no languages....

@kaolin
Copy link
Author

kaolin commented Jun 22, 2018

(I did realize that all the source syntaxes/languages were git submodules, so git submodule init, git submodule update will at least pull in the information to copy over... if you've git cloned the repo, versus using the tarball....)

@sharkdp sharkdp added the feature-request New feature or request label Jun 22, 2018
@sharkdp
Copy link
Owner

sharkdp commented Jun 22, 2018

Unfortunately, there is currently no way to do this (I would suggest to follow what you have done in your second comment).

I think it is a good idea to support this in general. I'll leave this ticket open as a feature request.

@Calinou
Copy link

Calinou commented Aug 11, 2018

This could be tangentially related to this issue, but I am unable to install a syntax file (beefsack/GDScript-sublime) if I don't install any themes at the same time. If I create an empty themes directory, then no themes are available at all.

❯ bat cache --init
[bat error]: Could not load themes from '/home/hugo/.config/bat/themes'

❯ tree -L 2 $(bat cache --config-dir)
/home/hugo/.config/bat
└── syntaxes
    └── GDScript-sublime

@sharkdp sharkdp modified the milestones: v0.5.0, v0.4.2 Aug 18, 2018
sharkdp added a commit that referenced this issue Aug 19, 2018
This commit separates the handling of syntax sets and theme sets. It
also changes the way how new syntax definitions are loaded from `bat`'s
configuration folder. New syntax definitions are now loaded *in
addition* to the ones that are stored in the `bat` binary by default.

This fixes #172
sharkdp added a commit that referenced this issue Aug 19, 2018
This commit separates the handling of syntax sets and theme sets. It
also changes the way how new syntax definitions are loaded from `bat`'s
configuration folder. New syntax definitions are now loaded *in
addition* to the ones that are stored in the `bat` binary by default.

This fixes #172
@sharkdp
Copy link
Owner

sharkdp commented Aug 19, 2018

This has been fixed in bat 0.5. Please see the release notes and README for details.

sharkdp added a commit that referenced this issue Aug 20, 2018
- New themes in `$BAT_CONFIG_DIR/themes` are now loaded *in addition* to
  the default themes (they may also override).
- The `Default.tmTheme` symlink is not necessary anymore.

This relates to #172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants