Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File extensions should be matched without case sensitivity #1854

Closed
michaelmior opened this issue Sep 16, 2021 · 2 comments · Fixed by #2181
Closed

File extensions should be matched without case sensitivity #1854

michaelmior opened this issue Sep 16, 2021 · 2 comments · Fixed by #2181
Labels
feature-request New feature or request
Milestone
v0.21.0

Comments

@michaelmior
Copy link

Perhaps there are some example use cases to the contrary, but in general it seems like it would preferable if file extensions were matched ignoring case. I recently experienced this with a file name that had the extension SQL instead of sql and bat did not automatically apply the desired highlighting.
@michaelmior michaelmior added the feature-request New feature or request label Sep 16, 2021
@keith-hall
Copy link
Collaborator

Thanks for reporting. We have fixed this upstream, and are waiting for a new release of the syntect dependency which will contain this fix. (See #1807 where it was first discovered.)

@michaelmior
Copy link
Author

Great! Thanks. Feel free to close this as it probably doesn't need a separate issue to be tracked.

@Enselic Enselic added this to the v0.19 milestone Dec 5, 2021
@Enselic Enselic removed this from the v0.19 milestone Mar 3, 2022
@Enselic Enselic added this to the v0.21.0 milestone Mar 30, 2022
Enselic added a commit to Enselic/bat that referenced this issue May 4, 2022
@Enselic
Bump to syntect 5.0.0 to e.g. start lazy-loading themes
cdbcb19 
Closes sharkdp#915
Closes sharkdp#951
Closes sharkdp#1846
Closes sharkdp#1854
@Enselic Enselic mentioned this issue May 4, 2022
Merged
Enselic added a commit that referenced this issue May 7, 2022
@Enselic
Bump to syntect 5.0.0 to e.g. start lazy-loading syntaxes (#2181)
7334ab4 
* Bump to syntect 5.0.0 to e.g. start lazy-loading themes

Closes #915
Closes #951
Closes #1846
Closes #1854

* Typo fix formated -> formatted

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging a pull request may close this issue.

Bump to syntect 5.0.0 to e.g. start lazy-loading syntaxes Enselic/bat
3 participants
@michaelmior @Enselic @keith-hall