Bat is broken for filenames that are prefixes of "cache"

[mk12]

The issue with files named "cache" was already identified in #245 and fixed in #275. However, the clap parser doesn't require an exact match: any prefix of the subcommand "cache" will do. So if you try bat c (or "ca", "cac", "cach"), one of the following will happen:

1. If there is a file named "cache", it will print that instead (the wrong file!).
2. Otherwise, it will print an error message about --build/--clear being required.

I think it's best to avoid subcommands and use something like --cache instead.

[sharkdp]

Which version of bat are you using? This should have been fixed and I can not reproduce this.

[TheSinding]

I just discovered this myself.
Version 0.10.0

I did bat c where c was a file and got the error

~ > bat c    
error: The following required arguments were not provided:
    <--build|--clear>

USAGE:
    bat cache [OPTIONS] <--build|--clear>

For more information try --help

[sharkdp]

I still can not reproduce this:

▶ bat c
[bat error]: 'c': No such file or directory (os error 2)

▶ bat cach
[bat error]: 'cach': No such file or directory (os error 2)

▶ echo "hello world" > c

▶ bat c
───────┬─────────────────────────────────────────────
       │ File: c
───────┼─────────────────────────────────────────────
   1   │ hello world
───────┴─────────────────────────────────────────────

▶ bat cach
[bat error]: 'cach': No such file or directory (os error 2)

▶ rm c

▶ echo "hello world" > cache

▶ bat c
[bat error]: 'c': No such file or directory (os error 2)

▶ bat cach
[bat error]: 'cach': No such file or directory (os error 2)

▶ bat cache
───────┬─────────────────────────────────────────────
       │ File: cache
───────┼─────────────────────────────────────────────
   1   │ hello world
───────┴─────────────────────────────────────────────

Is bat an alias for bat --some-option …? Can you show the exact steps to reproduce this, starting from an empty folder?

[sharkdp]

Oh, I know where the problem is. I have a bat config file that prevents this from happening. I can reproduce this if I remove my ~/.config/bat/config file.

Edit: Forgot to say: thank you for reporting this!

[TheSinding]

That makes sense, glad you could reproduce it.

…

On Fri, May 10, 2019, 17:58 David Peter ***@***.***> wrote: Oh, I know where the problem is. I have a bat config file that prevents this from happening. I can reproduce this if I remove my ~/.config/bat/config file. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#557 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKRMYYOHRJQATZVZJR3WVDPUWLRZANCNFSM4HKOWGQA> .

[sharkdp]

Fixed in v0.11.0.