Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PowerShell syntax test #1342

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Add PowerShell syntax test #1342

merged 1 commit into from
Oct 25, 2020

Conversation

dp304
Copy link
Contributor

@dp304 dp304 commented Oct 25, 2020

Part of the work for issue #1213.

A short PowerShell script and the corresponding syntax-highlighted output
has been added. The script exhibits many of the peculiarities of the
PowerShell syntax.

@dp304
Add PowerShell syntax test
90696fa 
Part of the work for issue sharkdp#1213.

A short PowerShell script and the corresponding syntax-highlighted output
has been added. The script exhibits many of the peculiarities of the
PowerShell syntax.
@dp304
Copy link
Contributor Author

dp304 commented Oct 25, 2020

The added source file appears in the repo as binary, because it is in UTF-16 big endian format, complete with that silly BOM (U+FEFF) at the beginning.
This is how PowerShell ISE (on Win7) saved it, so I guess this is the way it's authentic, but please let me know if it should be converted.

@sharkdp
Copy link
Owner

sharkdp commented Oct 25, 2020 •
edited
Loading

Thank you very much for your contribution!

The added source file appears in the repo as binary, because it is in UTF-16 big endian format, complete with that silly BOM (U+FEFF) at the beginning.
This is how PowerShell ISE (on Win7) saved it, so I guess this is the way it's authentic, but please let me know if it should be converted.

Sounds good to me. bat can handle UTF-16 just fine, so this seems like a good additional test.

@sharkdp sharkdp merged commit ec8072d into sharkdp:master Oct 25, 2020
@dp304
Copy link
Contributor Author

dp304 commented Nov 5, 2020

Thanks for merging! Can you please add the hacktoberfest-accepted label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dp304 @sharkdp