Using slice notation instead of as_ref #153
Conversation
| @@ -47,7 +47,7 @@ pub fn list_languages(assets: &HighlightingAssets, term_width: usize) { | |||
| } | |||
|
|
|||
| num_chars += new_chars; | |||
| print!("{}", Green.paint(word.as_ref())); | |||
| print!("{}", Green.paint(&word[..])); | |||
There was a problem hiding this comment.
it was word as &str before. is that better or worse?
There was a problem hiding this comment.
Frankly, I don't know, maybe it is a matter of taste.
Using slice notation is direct for me since I read about it in the Book; but I was not aware that &String can be casted to &str by as casting. Looking at Rustonomicon, I guess that this falls into the first case of cast (i.e. *T as *U where T, U: Sized), but I still don't know the underlying mechanism of this cast.
Edit: I think word as &str is type coercing using std::ops::Deref trait for String because the document says:
If
TimplementsDeref<Target = U>..., then: ...Values of type&Tare coerced to values of type&U
I would be happy with word as &str as well (which compile also for both stable and nightly).
There was a problem hiding this comment.
Thank you for investigating. I think the slice notation is perfectly fine here.
|
Thank you! |
That would fix the type annotation error discussed in #148