Support a hidden arg --no-custom-assets that skips loading assets from the cache #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Jul 28, 2021
sharkdp
reviewed
Jul 28, 2021
sharkdp
reviewed
Jul 28, 2021
sharkdp
reviewed
Jul 28, 2021
sharkdp
requested changes
Jul 28, 2021
Enselic
force-pushed
the
add-hidden-no-custom-assets-arg
branch
from
49a1e77
to
f92bf43
Compare
|
All comments should be addressed now, so feel free to take another look when you have time. |
sharkdp
reviewed
Jul 29, 2021
sharkdp
approved these changes
Jul 29, 2021
Enselic
force-pushed
the
add-hidden-no-custom-assets-arg
branch
from
f92bf43
to
1157c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main use-case I have in mind for this flag is to make it easy to parameterize hyperfine (
hyperfine --parameter-list assets --no-custom-assets, 'bat {assets} examples/simple.rs') to compare performance between custom vs integrated assets, as we work on #951. But I would be surprised if it would not come in handy for other uses as well in the future.I choose to name the arg
--no-custom-assetsrather than--no-cachein order to be more future-proof with upcoming changes. Since it is a hidden arg, I figured it would be OK to do it like this. I do not mention it in CHANGELOG.md though, since I don't think we need to make it publicly visible at this point. But let me know if you disagree!