Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated 'error-chain' with 'thiserror' #1820

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Replace deprecated 'error-chain' with 'thiserror' #1820

merged 4 commits into from
Aug 26, 2021

Commits on Aug 25, 2021

  1. Replace deprecated 'error_chain' with 'thiserror'

    @Enselic
    Enselic committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    571e9f7 View commit details
    Browse the repository at this point in the history

  2. Remove TODO on Msg(String) 

    The reason is simply that String does not implement Error, and that would
not be a good idea. See e.g.:
https://internals.rust-lang.org/t/impl-error-for-string/8881
    @Enselic
    Enselic committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    d23a55d View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Update CHANGELOG.md with 'thiserror' changes

    @Enselic
    Enselic committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    db68682 View commit details
    Browse the repository at this point in the history

  2. clippy: --allow clippy::unknown_clippy_lints

    @Enselic
    Enselic committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    330e11c View commit details
    Browse the repository at this point in the history