Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for special-casing
less
relies on the pager being specified as the literal string or using Unix-style paths. It also ignores the actual pager specified when calling it, so even if you setPAGER
/BAT_PAGER
to/my/path/to/less
,bat
will simply callless
.This PR treats any specified pager as a path and checks only the file stem so that
C:\foo\bar\less.exe
,/foo/bar/less
, andless
are all recognized. It also uses the specifiedless
.I managed to write a test for this by creating a stub
bin/less.rs
that verifies its arguments and the environment. However, this binary was installed along withbat
when runningcargo install
. I haven’t yet found a way to test the behaviour without this issue, so for the moment I can only offer the fix without the test (but with the assurance that I’ve tested its behaviour both manually and automatically).