Enabled build target for arm64 architecture #297
Conversation
rachitchokshi
changed the title
Cargo.toml
Outdated
| @@ -19,6 +19,7 @@ ansi_term = "0.11" | |||
| console = "0.6" | |||
| directories = "1.0" | |||
| lazy_static = "1.0" | |||
| libz-sys = "1.0.20" | |||
There was a problem hiding this comment.
When i was testing the build for the first time it was failing with error: failed to run custom build command for libz-sys v1.0.20. But right now i checked again and it takes care of it implicitly.
|
Thank you very much! Could you add a short comment why including |
|
Another thing I just noticed: If you look at 3e09950, there is a change in |
|
you are right @sharkdp ,sorry i did not test the deploy script properly as it required the release tag. |
| @@ -19,6 +19,8 @@ pack() { | |||
|
|
|||
| if [[ $TARGET == "arm-unknown-linux-gnueabihf" ]]; then | |||
| gcc_prefix="arm-linux-gnueabihf-" | |||
| elif [[ $TARGET == "aarch64-unknown-linux-gnu" ]]; then | |||
| gcc_prefix="aarch64-linux-gnu-" | |||
There was a problem hiding this comment.
Did you test this? Is the prefix really aarch64-linux-gnu- and not aarch64-linux-gnueabihf- or similar?
There was a problem hiding this comment.
Yes, it did execute successfully in my test release.
arm-unknown-linux-gnueabihf is for armhf architecture while aarch64-unknown-linux-gnu is for arm64.
| ;; | ||
| aarch64*) | ||
| architecture=arm64 | ||
| gcc_prefix="aarch64-linux-gnu-" |
There was a problem hiding this comment.
Yes, it did execute successfully in my test release.
| ;; | ||
| i686*) | ||
| architecture=i386 | ||
| gcc_prefix="" | ||
| ;; | ||
| aarch64*) |
There was a problem hiding this comment.
If this works, could we also enable this for arm?
There was a problem hiding this comment.
This PR enables build for aarch64, solving issue #258