Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nix from 0.26.4 to 0.29 #3112

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Bump nix from 0.26.4 to 0.29 #3112

merged 1 commit into from
Oct 25, 2024

Conversation

decathorpe
Copy link
Contributor

This supersedes #3089 and makes the necessary code changes to compile with nix 0.29. This actually makes it possible to drop the unsafe usage, because a File can be constructed from OwnedFd safely and without failing.

Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of unsafe code = nice (even in a test), let's merge!

@Enselic Enselic merged commit 649fb05 into sharkdp:master Oct 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants