Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print a horizontal header line when 'grid' style without 'header' style #579

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Print a horizontal header line when 'grid' style without 'header' style #579

merged 2 commits into from
Jul 26, 2019

Conversation

eth-p
Copy link
Collaborator

@eth-p eth-p commented May 31, 2019

Fixes #571

@sharkdp
Copy link
Owner

sharkdp commented Jul 24, 2019

Thank you! (sorry for not commenting earlier) Happy to merge this if the tests pass.

@eth-p
Copy link
Collaborator Author

eth-p commented Jul 24, 2019

It turns out that I forgot to update the snapshots when I added the top grid line.
They should be fixed now.

@sharkdp sharkdp merged commit 21821f1 into sharkdp:master Jul 26, 2019
@eth-p eth-p deleted the fix-571 branch July 26, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output looks unbalanced when using '--style=grid,numbers' without 'header'.
2 participants
@eth-p @sharkdp