-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display binary file content for bat -A #640
Conversation
Thank you very much for your contribution! There are a few things that could be improved. For binary files, the grid styling is not quite right:
Notice that the grid in the header-section is not joined with the lower part (
Implementation-wise, I think that the Lines 36 to 73 in c64ab29
This would have the added advantage that we could highlight the \x9a tokens in a nice way.
|
A more serious issue: I'm working on something... |
Closes #623. When the
-A
flag is supplied, attempts to print hex-escaped lines for binary files. The one caveat is it escapes non-ASCII characters, not just non-UTF-8.From what I could tell printing the hex-escaped version of UTF-8 text would be a lot more involved, but if there's an option I missed here I'm happy to make changes