Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump assets/syntaxes/01_Packages from 759d6ee to f36b8f8 #988

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 13, 2020

Bumps assets/syntaxes/01_Packages from 759d6ee to f36b8f8.

Commits
  • f36b8f8 [TCL] Support regex not in curly braces (#2204)
  • b770043 Simplify OpenGL package install in GitHub Action
  • 560b275 Try using GitHub Actions since Travis seems to have unconfigured itself
  • 318c1e8 Use build 4073 for tests
  • 412e900 [C++/ObjC++] Add C++20 coroutine keywords (#2198)
  • 76dac79 [Bash] Use LF as the default line ending (#2195)
  • bff207a [HTML] Update completions to provide kind info, use new features
  • 4cadb40 [PHP] Update completions with kind info, add parens to triggers
  • b3b3f23 [Java] Update completions with kind info
  • 2207f34 [Go] Update completions with kind info
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels May 13, 2020
@sharkdp
Copy link
Owner

sharkdp commented May 13, 2020

Before we merge this, I would like to set up a test suite that makes sure we don't run into regressions like #963, #914 or #988.

The way this could work would be to collect a large set of source files for all the different languages that bat can handle (we could start with the ones that are inside "Packages" and require this for new syntaxes in the future). We would then generate the syntax-highlighted versions of these source files via

bat --color=always --plain example.rs > example.rs.highlighted

and store the *.highlighted versions in the repository as well. Finally, we would set up a test (similar to the "snapshot tests") that would compare the output of the current version of bat with these stored versions.

We could use a specialized fixed highlighting theme for these tests, in order for theme changes not to require any updates of these files.

We certainly wouldn't catch all bugs with this method, as it relies on the content of the example files (more content is better, I guess). But we certainly wouldn't be surprised by things like #963, where the syntax highlighting for Markdown was essentially completely broken.

This collection of example files would certainly also be valuable for other sorts of tests. A possible source for such files could be http://rosettacode.org/wiki/Rosetta_Code, but licensing would need to be checked.

@sharkdp
Copy link
Owner

sharkdp commented Jun 3, 2020

@dependabot rebase

Bumps [assets/syntaxes/01_Packages](https://github.com/sublimehq/Packages) from `759d6ee` to `f36b8f8`.
- [Release notes](https://github.com/sublimehq/Packages/releases)
- [Commits](sublimehq/Packages@759d6ee...f36b8f8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/submodules/assets/syntaxes/01_Packages-f36b8f8 branch from 927ceb0 to e71f09a Compare June 3, 2020 07:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #988 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files          27       27           
  Lines        2287     2287           
=======================================
  Hits         1591     1591           
  Misses        696      696           
Flag Coverage Δ
#macos_latest 69.52% <ø> (ø)
#ubuntu_latest 69.38% <ø> (ø)
#windows_latest 68.99% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e9368...e71f09a. Read the comment docs.

@dependabot-preview
Copy link
Contributor Author

Superseded by #1119.

@dependabot-preview dependabot-preview bot deleted the dependabot/submodules/assets/syntaxes/01_Packages-f36b8f8 branch August 1, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants