Update crossterm to version 0.24 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary changes to be compatible with `crossterm = "0.24"` This change currently adapts to the newly added `crossterm::style::ContentStyle.underline_color` by setting it simply to the foreground color.
sharkdp
approved these changes
Jul 27, 2022
|
Thanks for the quick release! Don't know which terminals support the fancy underlines or if there is a good way to test for that. (crossterm PR which introduced it: crossterm-rs/crossterm#679) |
|
Sorry I introduced an incompatibility with that, some terminal emulators seem to take the crossterm underline color as a reason to blink. Patched by #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary changes to be compatible with
crossterm = "0.24"This change currently adapts to the newly added
crossterm::style::ContentStyle.underline_colorby setting it simply to the foreground color.
Addresses #49
Will require a new release to be usable for compatibility with new crossterm version