-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Options based configuration into CLI and Examples for BlueGiga #155
Comments
An options object would be useful for BlueZ implementation too. Mainly to specify a specific bluetooth adapter (eg hci0) instead of simply using the first available one. Kind of optional since multiple available bluetooth adapters seems like a bit of a edge case. Maybe best to open a separate issue to complete if this one is done? |
Let us focus on finishing bluez first. We see which delivery beat which and then we adjust :) |
I've tested today with BlueGiga on a RaspberryPi with the actual Master-branch - works like a charme!
..and it works. Also with two Hubs in parallel (ExampleTwoHubsMotorControl) 😄
Why do I mention it here? |
Oh that is nice. Create a PR updating the README second: Yes, I agree. We need to decouple the dependency to the bluetooth stacks in the tools etc. There is a "plugin"-like concept called AssemblyLoadContext which can load assemblies at runtime. With a small generic helper, all the CLI, Examples, TestScript Runner can dynamically load an adapter. The only thing I am not sure is, does it work with the |
I've tested on a Raspberry Pi 4. I will do another test on a Raspi 3 and also on an Ubuntu 20.0 LTS (PC-based). As soon as I have finished these tests, I will update the README. Shall I go for an own file BlueGigaReadme.md for bringing all the information for BlueGiga centralized or put it into the big README? It's more a question of wanted style from your side. |
That is indeed a good idea. Put it somewhere reasonable in the docs folder and link it from the main readme. That declutters the project start page. |
- Add separate BlueGiga documentation - stripped down README a so that BlueGiga is just referenced #155 non-breaking
- Enable usage of Configuration JSON file / command line input - Add Plugin Infrastructure for BLE adapters for CLIs - Enable VS Code Debugger to run .NET 5 builds - Add CliBase project to unify DI container creation for CLI projects - Rewrote SharpBrick.PoweredUp.WinRT/BlueGigaBLE into plugins and dereference from Examples and CLI - Add selection by command line of execute example #155 non-breaking
- Remove referenced dlls from published output - Fixed loading of JSON #155 non-breaking
- Fixed Examples, CLI, TestScript Projects - Fixed the documentation #155 breaking
BlueGiga in focus because currently the only one needing configuration
See details in #154
The text was updated successfully, but these errors were encountered: