Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break Hub into BaseHub and LwpHub #61

Closed
tthiery opened this issue Jul 15, 2020 · 0 comments · Fixed by #85
Closed

Break Hub into BaseHub and LwpHub #61

tthiery opened this issue Jul 15, 2020 · 0 comments · Fixed by #85
Labels
area-hubs breaking-change enhancement New feature or request
Milestone
v3.0 (breaking)

Comments

@tthiery
Copy link
Member

tthiery commented Jul 15, 2020 •
edited
Loading

WeDo will require this. Also maybe SPIKE Prime.

  • BaseHub contains all properties, alerts, etc functionality
  • LwpHub everyting related to LWP Protocol wireing
  • Rename IPoweredUpProtocol to ILegoWirelessProtocol

Lesson Learnt from #51
@tthiery tthiery added enhancement New feature or request area-hubs labels Jul 15, 2020
@tthiery tthiery added this to the v2.2 milestone Jul 30, 2020
@tthiery tthiery modified the milestones: v2.2, v3.0 - Breaking Changes Aug 9, 2020
tthiery added a commit that referenced this issue Aug 25, 2020
@tthiery
Rename PoweredUpProtocol into LegoWirelessProtocol
762f67e 
#61 breaking
tthiery added a commit that referenced this issue Aug 25, 2020
@tthiery
Rename PoweredUpMessage to LegoWirelessMessage
09d24f8 
#61 (breaking)
This was referenced Aug 25, 2020
Merged
Open
tthiery added a commit that referenced this issue Aug 31, 2020
@tthiery
Rename PoweredUpProtocol (#85)
1f6198a 
#61 (breaking)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-hubs breaking-change enhancement New feature or request
Projects
None yet
Milestone
v3.0 (breaking)
Development

Successfully merging a pull request may close this issue.

Rename PoweredUpProtocol sharpbrick/powered-up
1 participant
@tthiery