Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make discovery more user friendly #65

Closed
tthiery opened this issue Jul 25, 2020 · 0 comments · Fixed by #67
Closed

Make discovery more user friendly #65

tthiery opened this issue Jul 25, 2020 · 0 comments · Fixed by #67
Assignees
@tthiery
Labels
area-hubs enhancement New feature or request good first issue Good for newcomers
Milestone
v2.1

Comments

@tthiery
Copy link
Member

tthiery commented Jul 25, 2020

  • Add PowererdHost.DiscoverAsync<THub>() which only returns when a specific typed hubs arrive.
  • Remove mandatory cancellation token. Might scare beginner.
  • Update readme.
@tthiery tthiery added enhancement New feature or request good first issue Good for newcomers area-hubs labels Jul 25, 2020
@tthiery tthiery added this to the v2.1 milestone Jul 25, 2020
tthiery added a commit that referenced this issue Jul 28, 2020
@tthiery
Add DiscoverAsync method
105fc28 
- Add Example
- Add some logging in PoweredUpHost

#65 non-breaking
tthiery added a commit that referenced this issue Jul 28, 2020
@tthiery
Update README with simpler DiscoveryAsync
3607f65 
#65 non-breaking
@tthiery tthiery mentioned this issue Jul 28, 2020
Merged
@tthiery tthiery self-assigned this Jul 28, 2020
tthiery added a commit that referenced this issue Jul 30, 2020
@tthiery
Merge pull request #67 from sharpbrick/issue-65-simpler-discovery
5dd4123 
Make DiscoveryAsync more user friendly

#65 non-breaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthiery tthiery

Labels
area-hubs enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

Make DiscoveryAsync more user friendly sharpbrick/powered-up
1 participant
@tthiery