Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Code Cleanup (v1.0) #8

Closed
8 of 9 tasks
tthiery opened this issue Jun 7, 2020 · 0 comments
Closed
8 of 9 tasks

Breaking Code Cleanup (v1.0) #8

tthiery opened this issue Jun 7, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@tthiery
Copy link
Member

tthiery commented Jun 7, 2020 •
edited
Loading

  • Enum according to .NET Guidelines (flags plural, all other singular)
  • Enums of messages into global namespace (since also used by Functions, Devices, ..)
  • unit clarifications of all parameters (e.g. timeInMs)
  • remove abbreviations
  • add documentation
  • cleanup namespaces to allow regular users to only include one namespace
    • Remove Devices and Hub Namespace
    • Move Knowledge back into Protocol namespace
    • Move shared usage enums into root namespace
@tthiery tthiery added the enhancement New feature or request label Jun 7, 2020
tthiery added a commit that referenced this issue Jun 14, 2020
@tthiery
Cleanup Code
42964a4 
- Enum BatteryType
- Enum PowerdUpHubManufacturerData
- Enum ErrorCode
- Enum DeviceType
- Enum PowerdUpColor
- Enum SpecialSpeed
- Enum SpeedProfiles (flag => plural)

#8
tthiery added a commit that referenced this issue Jun 14, 2020
@tthiery
Code Cleanup
8b2ba14 
- Moved devices into root namespace
- Corrected typo in IPoweredUpDevice
- Corrected parameter naming from interface.

#8
tthiery added a commit that referenced this issue Jun 14, 2020
@tthiery
Code Cleanup
795184c 
- Move Hub to root namespace
- Fix SystemType namespace
- Fix Voltage namespace

#8
@tthiery tthiery changed the title Code Cleanup Breaking Code Cleanup (v1.0) Jun 14, 2020
@tthiery tthiery added this to the v1.0 milestone Jun 14, 2020
tthiery added a commit that referenced this issue Jun 14, 2020
@tthiery
Moved Protocol Knowledge into right namespace
ace053b 
#8
tthiery added a commit that referenced this issue Jun 14, 2020
@tthiery
Fix Code Warnings
2103471 
#8
tthiery added a commit that referenced this issue Jun 14, 2020
@tthiery
Fix Code Warnings
386d84b 
#8
tthiery added a commit that referenced this issue Jun 21, 2020
@tthiery
Add StopByBrake and StopByFloat, Guarding
d8c3467 
- BasicMotor StopByBrake and StopByFloat
- Guarding for methods whether device/hub is connected
- Fix naming of parameter

#8
tthiery added a commit that referenced this issue Jul 4, 2020
@tthiery
Fix documentation and minor code issues
3f61589 
#8
@tthiery tthiery closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@tthiery