add SystemTrainMotor #107
Merged
add SystemTrainMotor #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I take usually the liberty spying at https://github.com/nathankellenicki/node-poweredup ... they directly derive from BasicMotor ... so Power it is. No TachoMotor involved. |
tthiery
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the Train Motor as a BasicMotor. I'm not sure if that is correct though, but it does not seem to be able to get the speed from the device if I use TachoMotor. It works as expected (speed % and braking), tested it using a technic hub and a train motor.
Any power level under 10 will not make the/my motor run, I guess that aligns with the train remote supporting 10 different speed steps.
Closes #104