Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xamarin Bluetooth Stack (and Adjustment) #146

Merged
merged 11 commits into from
Mar 31, 2021

Conversation

Berdsen
Copy link
Contributor

@Berdsen Berdsen commented Mar 29, 2021

This will fix #69
As currently mentioned, you should take a look at the last commit.
All the language features remain for the PoweredUp library but the target framework changed.
Perhaps it might be enough for now and can be reworked later with .NET 6 which hopefully brings Desktop and Mobile together on the same base.

Furthermore I just could test it with Android for now. iOS might be a little bit harder, because it might be tricky to get the BT adress of the requested device. I'm currently checking on how I can test a iOS application to check if it will work.

A maintenance release might be a good option. But the other options will not be necessary duplicate implementations but just a different csproj file of the lib, reflecting the changes made in the last commit. And then two different sln files for each type of project. The rest could remain.

@tthiery
Copy link
Member

tthiery commented Mar 30, 2021

First Pass over it

  • The example app has to go to a separate repository. Happy to host it under sharpbrick org.
  • The examples situation I would love to discuss under Reorganize Examples Collection to be easier to maintain and invokable from Xamarin App #149
  • Regards Target Frameworking ... why not multi-targeting it then. I have to figure out, why I reverted it in the first place. I had it when I ported the framework to .NET 5 like you did it but with C# 9 features I dropped it.

@Berdsen
Copy link
Contributor Author

Berdsen commented Mar 30, 2021

I added multi-targets for NET5 and NETSTANDARD21. Looks good so far.
Would you create a repository for the app then? I would create a corresponding PR then into it, after extracting the app.
I would also adjust the app package to be org.sharpbrick.poweredup then.
Happy to discuss the extraction of the examples in #149 then

@tthiery
Copy link
Member

tthiery commented Mar 30, 2021

I added the repo. Copy your two or three examples meanwhile. I will work another day on proper permissions.

@Berdsen Berdsen closed this Mar 30, 2021
@Berdsen Berdsen reopened this Mar 30, 2021
@tthiery tthiery changed the title Add xamarin implementation Xamarin Bluetooth Stack (and Adjustment) Mar 30, 2021
@tthiery tthiery added area-bt-xamarin enhancement New feature or request labels Mar 30, 2021
@tthiery tthiery added this to the v4.0 (breaking) milestone Mar 30, 2021
@tthiery
Copy link
Member

tthiery commented Mar 30, 2021

@Berdsen Tell me when you are ready for review here

Copy link
Member

@tthiery tthiery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had time and did a full review pass as of now. There are some comments to address.

@tthiery
Copy link
Member

tthiery commented Mar 30, 2021

We will go the multi-targeting route if nothing crashes.

@Berdsen
Copy link
Contributor Author

Berdsen commented Mar 31, 2021

So I extracted the Xamarin app tested the Xamarin implementation with locally build nugets. At least for my "Vernie" the examples work :)
And also the CLI and .NET Example App work. So I would go for the multi-targeting 👍

@tthiery tthiery merged commit 970e1f7 into sharpbrick:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-bt-xamarin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Xamarin support
3 participants