Disabled cache use on discovery modes #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2024 20:45
…a when discovery devices and modes.
tthiery
reviewed
Feb 11, 2024
| @@ -84,6 +87,11 @@ public async Task SendMessageAsync(LegoWirelessMessage message) | |||
| throw; | |||
| } | |||
| } | |||
|
|
|||
| private bool UseCachedInformation() | |||
There was a problem hiding this comment.
The only feedback here: Why using a method here instead of a property?
There was a problem hiding this comment.
Agreed, habit I guess :)
|
Thanks a lot for this one 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #195
For me without the Large motor fix in the other PR, this will actually make discovery and device list work. This should not affect normal operation.
#195 non-breaking