Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift4] advanced(by:) ->index(_:, offsetBy:) #57

Merged
merged 1 commit into from
Jul 28, 2017
Merged

[Swift4] advanced(by:) ->index(_:, offsetBy:) #57

merged 1 commit into from
Jul 28, 2017

Conversation

wspl
Copy link
Contributor

@wspl wspl commented Jul 27, 2017

#56 Fixed

@sharplet
Copy link
Owner

Thanks for the contribution! This looks good to me, though I'm not sure why the one build is failing. Maybe swiftenv install --list-snapshots and swiftenv install <snapshot> disagree about what the latest snapshot actuall is? I'll do some manual testing later today if CI keeps failing.

@sharplet
Copy link
Owner

Fixes #56.

(I believe the issue number has to appear after the keyword for GitHub to automatically close the issue when this is merged.)

@sharplet
Copy link
Owner

Did some manual testing with the latest Swift 4 snapshot on Linux, found this:

/Regex/Source/Foundation+Ranges.swift:4:34: error: use of undeclared type 'TextCheckingResult'
typealias NSTextCheckingResult = TextCheckingResult
                                 ^~~~~~~~~~~~~~~~~~

Don't have time to debug this further today, hoping to get to it tomorrow.

@sharplet sharplet merged commit c4eddc4 into sharplet:master Jul 28, 2017
sharplet added a commit that referenced this pull request Jul 28, 2017
@sharplet
Copy link
Owner

There are some unrelated issues with the latest Swift 4 snapshots, but otherwise this seems just fine, so I've merged it manually. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants