Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname authentication #44

Merged
merged 2 commits into from
Dec 10, 2014
Merged

Nickname authentication #44

merged 2 commits into from
Dec 10, 2014

Conversation

clarissavazquez
Copy link
Contributor

Solves issue #32:
Added a line that would read a password txt file so that it identifies with the server.

@shaunagm
Copy link
Owner

This is great, but we'll want the bot to work when it's not a registered nick. I think what would be great is to have this little piece of code put in a conditional variable like is_registered and that variable put with the user-defined variables up at the top of bot.py.

@SwartzCr
Copy link

That is to say, that if the Bot's name isn't registered with the IRC server, we don't want it to go through all of the trouble of trying to load a password file and messaging the NickServ, just like we've set up which channels and servers to join at the top, we should add something to help us know whether or not to bother with trying to use the IDENTIFY command.

@shaunagm
Copy link
Owner

Hi Clarissa - thanks for working on WelcomeBot today! I saw that you updated your fork. Don't forget to submit a pull request as well so that I can merge your changes. :)

@shaunagm
Copy link
Owner

Sorry for the delay on this! Thanks for the contribution. :)

shaunagm added a commit that referenced this pull request Dec 10, 2014
@shaunagm shaunagm merged commit 971c13c into shaunagm:master Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants